Fix "ReferenceError: event is not defined" on Firefox#213
Fix "ReferenceError: event is not defined" on Firefox#213fabriziocucci wants to merge 1 commit intojavaee:masterfrom
Conversation
While on Chrome the problem is not visible, on Firefox the "New items size: ..." message is not shown due to the ReferenceError.
|
Can one of the admins verify this patch? |
|
Hi Fabrizio, nice catch, thanks. Unfortunately, in order to merge the pull request, you would have to sign Oracle Contributor Agreement. It usually takes some time (multiple weeks) to be processed. Please, let me know, if you are willing to do it or if we should fix this via internal commit. Thanks, Adam |
|
Hi Adam, thanks for your answer. I was under the impression that I did already signed the OCA but I can't find myself in the list so probably I was wrong. I would be more than happy to go through the process since I'm planning to contribute. I'll try to sign it today but I'll give you confirmation as soon as possible. Thanks, |
|
Hi Fabrizio, glad to hear that. If you have the impression, that you already sent the OCA, please check your inbox first, maybe you really did and the problem is on our side. If so, please let me know and I would try to ping our colleague, that takes care of that. Thanks, |
|
Hi Adam, I just double checked: I did sign a contribution agreement recently but it was for another project! :) So, tomorrow I will print the OCA, sign it, scan it and send it to oracle-ca_us [at] oracle [dot] com. Thanks, |
|
Mission accomplished! 😎 I will let you know as soon as I get back the confirmation. Thanks, |
|
Fabrizio, your OCA is now approved. Thanks, |
|
Apparently, this sample has been split in two:
Re-proposing fix for both samples here. |
While on Chrome the problem is not visible, on Firefox the "New items size: ..." message is not shown due to the ReferenceError.